feat: populate packageName from package.json #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
approved these changes
Oct 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 81.68% 81.68%
=======================================
Files 24 24
Lines 2964 2964
Branches 246 246
=======================================
Hits 2421 2421
Misses 531 531
Partials 12 12Continue to review full report at Codecov.
|
joeldodge79
reviewed
Feb 25, 2021
| @@ -81,6 +89,7 @@ export class Node extends ReleasePR { | |||
| changelogEntry, | |||
| version: candidate.version, | |||
| packageName: this.packageName, | |||
| contents, | |||
There was a problem hiding this comment.
@bcoe I just discovered a bug here while switching from sandbox.stub to using a mock: it caught an unexpected extra call to get the contents for package.json. The reason is that the PackageJson constructor was never updated to set this.contents so GitHub.getChangeSet() has to reach back out to to get it. PR coming up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #289.