fix(java): handle version manifest snapshot release version #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
======================================
Coverage 81.9% 81.9%
======================================
Files 24 24
Lines 2978 2978
Branches 249 250 +1
======================================
Hits 2439 2439
Misses 529 529
Partials 10 10
Continue to review full report at Codecov.
|
bcoe
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scripts that generate the initial
versions.txtmanifest do not know what the current last released version was so it fills it in with the current snapshot version. If this happens, when it comes to release time, we should handle that in theversions.txtfile's replacements.