Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): support processing footers in gapics #711

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jan 21, 2021

Because we need to filter the commits found in the footer of a
commit we needed a hook to filter commits for the changelog. This
can't be done in the releaser as it only has the concept of raw
commits.Added the idea of supplying an optional commit filter to
ConventionalCommits.

Because we need to filter the commits found in the footer of a
commit we needed a hook to filter commits for the changelog. This
can't be done in the releaser as it only has the concept of raw
commits.Added the idea of supplying an optional commit filter to
ConventionalCommits.
@codyoss codyoss requested a review from bcoe January 21, 2021 21:05
@codyoss codyoss requested a review from a team as a code owner January 21, 2021 21:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #711 (efa428a) into master (0258bd6) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   86.96%   87.02%   +0.05%     
==========================================
  Files          55       55              
  Lines        6673     6696      +23     
  Branches      594      627      +33     
==========================================
+ Hits         5803     5827      +24     
+ Misses        869      868       -1     
  Partials        1        1              
Impacted Files Coverage Δ
src/conventional-commits.ts 99.20% <100.00%> (+0.46%) ⬆️
src/releasers/go-yoshi.ts 94.59% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0258bd6...efa428a. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach you've come up with 👍 one thought, perhaps we could just default the filter to: () => true, then we don't need to do the optional call logic.

src/conventional-commits.ts Outdated Show resolved Hide resolved
src/conventional-commits.ts Outdated Show resolved Hide resolved
@codyoss codyoss requested a review from bcoe January 22, 2021 15:10
@bcoe bcoe merged commit 08d8986 into master Jan 22, 2021
@bcoe bcoe deleted the parse-footers-go branch January 22, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants