Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tagging the release also comments on the release PR #751

Merged
merged 5 commits into from
Feb 5, 2021

Conversation

chingor13
Copy link
Contributor

Fixes #728

@chingor13 chingor13 requested a review from a team as a code owner February 5, 2021 22:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #751 (57fec65) into master (809f819) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   89.22%   89.27%   +0.04%     
==========================================
  Files          57       57              
  Lines        7315     7348      +33     
  Branches      685      687       +2     
==========================================
+ Hits         6527     6560      +33     
  Misses        787      787              
  Partials        1        1              
Impacted Files Coverage Δ
src/github-release.ts 97.32% <100.00%> (+0.08%) ⬆️
src/github.ts 86.62% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809f819...6149ddb. Read the comment docs.

src/github-release.ts Outdated Show resolved Hide resolved
@bcoe bcoe merged commit f78fc93 into googleapis:master Feb 5, 2021
@chingor13 chingor13 deleted the release-comment branch February 5, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: tagging a release should comment on the release PR
2 participants