Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Please pull request was not created after pull requests with releasable units #4134

Closed
suztomo opened this issue Aug 11, 2022 · 4 comments
Assignees
Labels
bot: release-trigger priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Aug 11, 2022

Release Please's release pull request was not craeted after googleapis/java-orchestration-airflow#218 ("deps" is a releasable unit) was merged.

image

chingor@ added "release-please:force-run" label to the pull request 218 and Release Please pull request was created.

Similar issue was observed in

When it was merged 9 days ago, Release Please pull request was not created.

@suztomo suztomo added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 11, 2022
@chingor13
Copy link
Contributor

From the logs, I could not find any errors in around that time frame. I also could not find any webhook received for that event. The GItHub API has an endpoint we can try to use to find the attempted delivery: https://docs.github.com/en/rest/apps/webhooks#list-deliveries-for-an-app-webhook

@suztomo
Copy link
Member Author

suztomo commented Aug 11, 2022

I added few more example pull requests there. They all merged almost the same time on August 2nd.

@SurferJeffAtGoogle
Copy link
Contributor

Why was this issue opened on this repository instead of https://github.com/googleapis/release-please?

@suztomo
Copy link
Member Author

suztomo commented Sep 22, 2022

I might get confused about the repository. https://github.com/googleapis/release-please sounds suitable. Can you move this there?

@chingor13 chingor13 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: release-trigger priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants