Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Cop: when more than N tests fail in a package, group them into a single issue #550

Closed
tbpg opened this issue May 15, 2020 · 1 comment · Fixed by #595
Closed

Build Cop: when more than N tests fail in a package, group them into a single issue #550

tbpg opened this issue May 15, 2020 · 1 comment · Fixed by #595
Assignees
Labels
bot: flakybot good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tbpg
Copy link
Contributor

tbpg commented May 15, 2020

If something is wrong with an entire package, all of the tests in that package can fail. This can lead to filing dozens of issues at a time. We should have a stopgap solution to avoid filing dozens of issues at once.

Proposal:

  • If more than 10 issues fail in a single build, file an issue with the title, "packagename: many tests failed"
  • Include the name of every failed test in the body of the issue.
  • The issue is closed when all of the tests pass for that package.
  • No new issues should be opened for that package.
  • If there are already individual issues for some of the failed tests, we should leave them open and reference them in the overall issue.
    • When that test starts passing, we can close the individual issue.
    • If the test fails after the issue is closed, we should leave it closed and not mark it flaky. We can comment on the issue
@tbpg tbpg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 15, 2020
@tbpg tbpg self-assigned this May 15, 2020
@bcoe
Copy link
Contributor

bcoe commented May 15, 2020

A couple thoughts:

Include the name of every failed test in the body of the issue.

I like this idea, you might look at GitHub markdown's support of blocks of text that can be minimized and maximized, if you're finding the size of the message is ridiculous.

If more than 10 issues fail in a single build, file an issue with the title, "packagename: many tests failed"

This sounds like a reasonable default configuration to me, you might consider it being something we could set in a config file though.


In general I'm pro this approach 👍

@tbpg tbpg added good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. labels May 26, 2020
@tbpg tbpg removed their assignment May 26, 2020
@tbpg tbpg self-assigned this Jun 12, 2020
@bcoe bcoe closed this as completed in #595 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: flakybot good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants