feat: support enhanced retry settings #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great!! Thanks, @stephenplusplus !!! |
|
Woo, thanks! I have merged and released under 4.2.0. |
|
@stephenplusplus I am unable to access these new fields after upgrading to 4.2.0. Does https://github.com/stephenplusplus/retry-request/blob/master/index.d.ts need to be updated? It does not contain the new parameters. Can you please regenerate it? |
|
Fixed in 4.2.1. Good catch! |
|
Thanks @stephenplusplus !! |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 11, 2022
🤖 I have created a release *beep* *boop* --- ## [4.2.0](v4.1.0...v4.2.0) (2022-04-06) ### Features * support enhanced retry settings ([#35](#35)) ([0184676](0184676)) ### Bug Fixes * add new retry options to types ([#36](#36)) ([3f10798](3f10798)) * correctly calculate retry attempt ([#33](#33)) ([4c852e2](4c852e2)) * use extend instead of object.assign ([#37](#37)) ([8c8dcdd](8c8dcdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: googleapis/nodejs-common#674
This adds 3 additional configuration settings:
maxRetryDelay, default: 64retryDelayMultiplier, default: 2totalTimeout, default: 600cc @shaffeeullah