Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: drop node 10 #68

Merged
merged 3 commits into from May 4, 2022
Merged

build!: drop node 10 #68

merged 3 commits into from May 4, 2022

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner April 22, 2022 18:25
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 22, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022
@sofisl
Copy link
Contributor

sofisl commented May 3, 2022

Would you mind also upgrading mocha, and confirming that you added the legacy tag? Thanks!

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 4, 2022
@ddelgrosso1
Copy link
Contributor Author

ddelgrosso1 commented May 4, 2022 •
edited

@sofisl update mocha from ^9.0.0 -> ^9.2.2. Legacy-10 tag is created.

@sofisl sofisl merged commit 00ec90c into googleapis:main May 4, 2022
@release-please release-please bot mentioned this pull request May 4, 2022
Merged
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@summer-ji-eng summer-ji-eng summer-ji-eng approved these changes

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ddelgrosso1 @sofisl @summer-ji-eng