Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: move minimum version to node 14 #96

Merged
merged 2 commits into from Jul 20, 2023
Merged

chore!: move minimum version to node 14 #96

merged 2 commits into from Jul 20, 2023

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner July 20, 2023 14:34
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node12/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 20, 2023
@ddelgrosso1 ddelgrosso1 reopened this Jul 20, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2023
@ddelgrosso1 ddelgrosso1 merged commit 2167a91 into main Jul 20, 2023
19 checks passed
@ddelgrosso1 ddelgrosso1 deleted the node-14-update branch July 20, 2023 17:56
@ddelgrosso1 ddelgrosso1 added release-please:force-run To run release-please and removed release-please:force-run To run release-please labels Jul 20, 2023
@release-please release-please bot mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ddelgrosso1 @sofisl @yoshi-kokoro