Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide an access object for the metadata server #53

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: Provide an access object for the metadata server #53

merged 1 commit into from
Oct 31, 2023

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Oct 26, 2023 •
edited

Also includes:

  • a documentation clarification in LazyValue that was recommended in an earlier PR
  • a few tweaks to timing-sensitive tests in LazyValue so the tests are more robust in test environments with less predictable timing such as Mac VMs on GitHub Actions.

@dazuma dazuma requested a review from a team as a code owner October 26, 2023 17:42
@dazuma dazuma mentioned this pull request Oct 26, 2023
Merged
@dazuma dazuma marked this pull request as draft October 27, 2023 01:41
@dazuma dazuma force-pushed the pr/mds-access branch 2 times, most recently from af6e178 to 4e0e3d6 Compare October 27, 2023 18:58
@dazuma dazuma marked this pull request as ready for review October 30, 2023 23:50
@dazuma dazuma merged commit 1551abe into googleapis:main Oct 31, 2023
10 checks passed
@release-please release-please bot mentioned this pull request Oct 31, 2023
Merged
@dazuma dazuma deleted the pr/mds-access branch October 31, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dazuma @bajajneha27