Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): add empty string validation for emulator host #73

Merged
merged 2 commits into from Nov 29, 2023
Merged

fix(spanner): add empty string validation for emulator host #73

merged 2 commits into from Nov 29, 2023

Conversation

NivedhaSenthil
Copy link
Member

@NivedhaSenthil NivedhaSenthil commented Nov 27, 2023 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
  • Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
  • Update code documentation if necessary.

closes: #69

@NivedhaSenthil NivedhaSenthil requested review from a team as code owners November 27, 2023 05:52
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Nov 27, 2023
SandeepTuniki
SandeepTuniki approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@SandeepTuniki SandeepTuniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SandeepTuniki SandeepTuniki merged commit 7ee6600 into main Nov 29, 2023
14 of 17 checks passed
@SandeepTuniki SandeepTuniki deleted the host_validation branch November 29, 2023 06:47
@release-please release-please bot mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandeepTuniki SandeepTuniki SandeepTuniki approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty string for emulator_host: causes runaway Ruby process
2 participants
@NivedhaSenthil @SandeepTuniki