New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): Support directed read options #75
Conversation
…anner into support_directed_read
…anner into support_directed_read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested minor changes for improvement. But otherwise, LGTM.
google-cloud-spanner/lib/google/cloud/spanner/batch_snapshot.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/lib/google/cloud/spanner/batch_snapshot.rb
Outdated
Show resolved
Hide resolved
.github/workflows/spanner-integration-tests-against-emulator.yaml
Outdated
Show resolved
Hide resolved
google-cloud-spanner/lib/google/cloud/spanner/batch_snapshot.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/lib/google/cloud/spanner/batch_snapshot.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/lib/google/cloud/spanner/batch_snapshot.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/test/google/cloud/spanner/client/execute_query_test.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/test/google/cloud/spanner/client/execute_query_test.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please fix failing builds.
Where do we have the samples for this feature?
Co-authored-by: Sri Harsha CH <57220027+harshachinta@users.noreply.github.com>
Benchmarking failure is unrelated to the changes, it has to be handled separately. Samples PR is in another repo GoogleCloudPlatform/ruby-docs-samples#1193 |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
bundle exec rake ci
in the gem subdirectory.closes: #<issue_number_goes_here>