Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): Support directed read options #75

Merged
merged 29 commits into from Jan 8, 2024

Conversation

NivedhaSenthil
Copy link
Member

  • Support directed_read_options at client creation
  • Pass on the options to session when session is created from client
  • Support directed_read_options at per request level for streaming_reads and streaming_query_execution
  • Options set at request level takes precedence at the session
  • Add units to assert the option passing and precedence
  • Add acceptance test to test one happy path passing directed_read_options

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
  • Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
  • Update code documentation if necessary.

closes: #<issue_number_goes_here>

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Dec 5, 2023
@NivedhaSenthil NivedhaSenthil marked this pull request as ready for review December 11, 2023 08:10
@NivedhaSenthil NivedhaSenthil requested review from a team as code owners December 11, 2023 08:10
Copy link
Contributor

@SandeepTuniki SandeepTuniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested minor changes for improvement. But otherwise, LGTM.

@NivedhaSenthil NivedhaSenthil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2024
Copy link

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix failing builds.
Where do we have the samples for this feature?

Co-authored-by: Sri Harsha CH <57220027+harshachinta@users.noreply.github.com>
@NivedhaSenthil
Copy link
Member Author

Benchmarking failure is unrelated to the changes, it has to be handled separately. Samples PR is in another repo GoogleCloudPlatform/ruby-docs-samples#1193

@NivedhaSenthil NivedhaSenthil merged commit 63bedd4 into main Jan 8, 2024
16 of 17 checks passed
@NivedhaSenthil NivedhaSenthil deleted the support_directed_read branch January 8, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants