Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump up minimum version of google-cloud-spanner-v1 to 0.19.0 #79

Merged
merged 1 commit into from Jan 24, 2024

Conversation

SandeepTuniki
Copy link
Contributor

The handwritten client supports Directed Read Options, so the dependency version of google-cloud-spanner-v1 has to be at least 0.19.0.

Unit tests were failing on my local system because of this.

@SandeepTuniki SandeepTuniki requested review from a team as code owners January 23, 2024 13:17
Copy link

conventional-commit-lint-gcf bot commented Jan 23, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a fix: since it's a bug fix and we probably want it to appear in release notes and trigger a release.

@SandeepTuniki SandeepTuniki changed the title chore: Bump up minimum version of spanner-v1 gem fix: Bump up minimum version of spanner-v1 gem Jan 24, 2024
@SandeepTuniki SandeepTuniki changed the title fix: Bump up minimum version of spanner-v1 gem fix: Bump up minimum version of google-cloud-spanner-v1 gem Jan 24, 2024
@SandeepTuniki SandeepTuniki changed the title fix: Bump up minimum version of google-cloud-spanner-v1 gem fix: Bump up minimum version of google-cloud-spanner-v1 to 0.19.0 Jan 24, 2024
@SandeepTuniki
Copy link
Contributor Author

SandeepTuniki commented Jan 24, 2024

I think this should be a fix: since it's a bug fix and we probably want it to appear in release notes and trigger a release.

Modified it to fix:

@SandeepTuniki SandeepTuniki merged commit ba27420 into main Jan 24, 2024
16 of 18 checks passed
@SandeepTuniki SandeepTuniki deleted the bump-spanner-v1-version branch January 24, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants