feat(Spanner): support max_commit_delay for commit_options #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandeepTuniki
approved these changes
Feb 5, 2024
google-cloud-spanner/test/google/cloud/spanner/convert/number_to_duration_test.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/test/google/cloud/spanner/client/commit_test.rb
Outdated
Show resolved
Hide resolved
| @@ -1141,6 +1145,10 @@ def upsert table, rows, commit_options: nil, request_options: nil | |||
| # * `:return_commit_stats` (Boolean) A boolean value. If `true`, | |||
| # then statistics related to the transaction will be included in | |||
| # {CommitResponse}. Default value is `false` | |||
| # * `:maxCommitDelay` (Numeric) The amount of latency in millisecond in this request | |||
| # is willing to incur in order to improve throughput. | |||
| # The commit delay must be at least 0ms and at most 500ms | |||
There was a problem hiding this comment.
For my understanding, what happens if the user value is out of this range? Will it be ignored? Or will the backend throw some kind of exception?
There was a problem hiding this comment.
An error is thrown from backend telling the value is out of range.
nginsberg-google
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
bundle exec rake ciin the gem subdirectory.closes: #<issue_number_goes_here>