Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add rest_numeric_enums to Ruby build rule template #115

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Sep 27, 2022

The current Ruby build rules take and ignore **kwargs, so this should be safe even before the build rules have been updated to recognize this parameter explicitly.

@dazuma dazuma marked this pull request as ready for review September 27, 2022 18:59
@dazuma dazuma requested a review from a team as a code owner September 27, 2022 18:59
Copy link
Member

@viacheslav-rostovtsev viacheslav-rostovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dazuma dazuma merged commit 5f5ba98 into googleapis:main Oct 28, 2022
@dazuma dazuma deleted the pr/numeric-enums-ruby branch April 27, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants