Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically determine protobuf version in build.gradle. #1757

Closed
JoeWang1127 opened this issue Jun 6, 2023 · 0 comments · Fixed by #1753
Closed

Dynamically determine protobuf version in build.gradle. #1757

JoeWang1127 opened this issue Jun 6, 2023 · 0 comments · Fixed by #1753
Assignees
@JoeWang1127
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@JoeWang1127
Copy link
Collaborator

JoeWang1127 commented Jun 6, 2023 •
edited
Loading

For self-service clients, e.g., google/maps/fleetengine, use gradle to build the client library. The protobuf version is defined in gax-java, which is not synced with protobuf version defined in googleapis.

This result in build failures when the protobuf version in googleapis is higher than version in gax-java (code generated by higher version of proto compiler may not compatible with lower version protobuf runtime environment).

Therefore, the protobuf version in gax-java should be synced with protobuf version in googleapis, rather than hard coded in a property file.

See b/284292352 for more info.
@JoeWang1127 JoeWang1127 linked a pull request Jun 6, 2023 that will close this issue
feat: dynamically determine protobuf version in build.gradle #1753
Merged
@JoeWang1127 JoeWang1127 mentioned this issue Jun 6, 2023
Merged
@emmileaf emmileaf added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 7, 2023
@JoeWang1127 JoeWang1127 self-assigned this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeWang1127 JoeWang1127

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: dynamically determine protobuf version in build.gradle googleapis/sdk-platform-java
2 participants
@emmileaf @JoeWang1127