Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: auto-value version 1.10.2 #1859

Merged
merged 2 commits into from
Jul 19, 2023
Merged

deps: auto-value version 1.10.2 #1859

merged 2 commits into from
Jul 19, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jul 18, 2023 •
edited
Loading

This should be tied with googleapis/java-shared-config#632

@suztomo suztomo requested a review from a team as a code owner July 18, 2023 15:40
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 18, 2023
@suztomo
Copy link
Member Author

suztomo commented Jul 18, 2023

The enforcer rule check failed:

[INFO] --- maven-enforcer-plugin:3.1.0:enforce (enforce) @ google-cloud-core ---
[INFO] Adding ignore: module-info
[INFO] Adding ignore: META-INF/versions/*/module-info
Error:  Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.auto.value:auto-value-annotations:1.10.1 paths to dependency are:
+-com.google.cloud:google-cloud-core:2.21.1-SNAPSHOT
  +-com.google.auto.value:auto-value-annotations:1.10.1
and
+-com.google.cloud:google-cloud-core:2.21.1-SNAPSHOT
  +-com.google.api:api-common:2.14.1-SNAPSHOT
    +-com.google.auto.value:auto-value-annotations:1.10.1 (managed) <-- com.google.auto.value:auto-value-annotations:1.10.2
and
+-com.google.cloud:google-cloud-core:2.21.1-SNAPSHOT
  +-com.google.auth:google-auth-library-oauth2-http:1.19.0
    +-com.google.auto.value:auto-value-annotations:1.10.1 (managed) <-- com.google.auto.value:auto-value-annotations:1.10.1
]

It seems googleapis/java-shared-config#632 needs to happens first, and it seems good to have the auto library released with the new shared config.

@lqiu96 lqiu96 mentioned this pull request Jul 19, 2023
Closed
4 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2023
@lqiu96
Copy link
Contributor

lqiu96 commented Jul 19, 2023

All checks are green. Merging in autovalue 1.10.2

@lqiu96 lqiu96 merged commit 54843c9 into googleapis:main Jul 19, 2023
23 checks passed
@release-please release-please bot mentioned this pull request Jul 19, 2023
Merged
@suztomo suztomo deleted the auto-value-annotations-1.10.2 branch July 20, 2023 01:25
@suztomo
Copy link
Member Author

suztomo commented Jul 20, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suztomo @lqiu96