Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace graal-sdk version declaration with properties placeholder #2120

Merged
merged 2 commits into from Oct 18, 2023
Merged

feat: replace graal-sdk version declaration with properties placeholder #2120

merged 2 commits into from Oct 18, 2023

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 13, 2023 •
edited

Preparing for java-shared-config with googleapis/java-shared-config#683

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 13, 2023
@mpeddada1 mpeddada1 marked this pull request as ready for review October 18, 2023 13:33
@mpeddada1 mpeddada1 requested a review from a team as a code owner October 18, 2023 13:33
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mpeddada1 mpeddada1 merged commit e5247ba into main Oct 18, 2023
37 checks passed
@mpeddada1 mpeddada1 deleted the graal-version-declaration branch October 18, 2023 14:10
@release-please release-please bot mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpeddada1 @lqiu96