Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Add section on samples in templated CONTRIBUTING.rst #1124

Closed
parthea opened this issue Jun 17, 2021 · 2 comments
Closed

[Python] Add section on samples in templated CONTRIBUTING.rst #1124

parthea opened this issue Jun 17, 2021 · 2 comments
Assignees
@leahecole
Labels
lang: python Issues specific to Python. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@parthea
Copy link
Contributor

parthea commented Jun 17, 2021

python-compute has a section on Samples and code snippets in CONTRIBUTING.rst. This could be added to the templated CONTRIBUTING.rst doc here so it can be used in all repos.
@parthea parthea added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. lang: python Issues specific to Python. labels Jun 17, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 17, 2021
@parthea parthea mentioned this issue Jun 17, 2021
Merged
1 task
@parthea parthea added the good first issue This issue is a good place to started contributing to this repository. label Jun 17, 2021
@m-strzelczyk m-strzelczyk self-assigned this Jul 15, 2021
@m-strzelczyk m-strzelczyk mentioned this issue Jul 15, 2021
Merged
@parthea
Copy link
Contributor Author

parthea commented Jul 20, 2021

@busunkim96 @leahecole #1159 was merged this morning. I understand there are some tweaks needed as the code snippet may not work on all repos. I'm going to keep this issue open to track the fix.

@parthea parthea assigned leahecole and busunkim96 and unassigned m-strzelczyk Jul 20, 2021
@parthea parthea removed the good first issue This issue is a good place to started contributing to this repository. label Aug 1, 2021
@leahecole
Copy link
Contributor

Given the monorepo migration, I think we can close this @parthea, but if you think it should be reopened please do so and add any additional context about its progress/relevance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leahecole leahecole

Labels
lang: python Issues specific to Python. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@parthea @leahecole @busunkim96 @m-strzelczyk