Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

stream_builder.h asserts in open #60

Closed
philburk opened this issue Jun 20, 2017 · 1 comment
Closed

stream_builder.h asserts in open #60

philburk opened this issue Jun 20, 2017 · 1 comment

Comments

@philburk
Copy link

philburk commented Jun 20, 2017 •
edited
Loading

aaudio/utils/stream_builder.h assert(false) in the open() method seems harsh for something that can easily fail.
If the caller requests EXCLUSIVE mode then on some platforms it will succeed and on some platforms it will crash. Better to return nullptr and check in caller.
@dturner
Copy link
Contributor

dturner commented Jul 6, 2017

This class has been removed

@dturner dturner closed this as completed Jul 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dturner @philburk