Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

@core-drawer-toggle vs #edgeSwipeOverlay #48

Open
robrez opened this issue Feb 6, 2015 · 2 comments
Open

@core-drawer-toggle vs #edgeSwipeOverlay #48

robrez opened this issue Feb 6, 2015 · 2 comments

Comments

@robrez
Copy link

robrez commented Feb 6, 2015

Setup:

    <core-drawer-panel>
      <core-header-panel drawer>
        <div> Toolbar </div>
        <div> Drawer content... </div>
      </core-header-panel>
      <core-header-panel main>
        <div> <core-icon-button icon="menu" core-drawer-toggle/> </div>
        <div> Main content... </div>
      </core-header-panel>
    </core-drawer-panel>

The 20px width of core-drawer-panel>#edgeSwipeOverlay can make taps of @core-drawer-toggle seem non-responsive.

@core-drawer-toggle's container can be given padding/margin-left to mask the issue but the icon looks a bit out-of-place.

I don't feel like there is any great "solution". What about an attribute to specify #edgeSwipeOverlay.style.top?? I'm guessing some might frown upon the swipe area not spanning the full viewport height.

@evancaldwell
Copy link

I'm also running into this. My first thought was the same as @robrez - push the edgeSwipeOverlay down since the menu tap results in identical behavior.

@nomego
Copy link

nomego commented Feb 25, 2015

In the case where core-drawer-panel is used on desktop with narrow, the #edgeSwipeOverlay also covers the scrollbar if main needs it, effectively disabling it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants