Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit tests more nuanced. #69

Closed
chihuahua opened this issue Apr 5, 2017 · 0 comments
Closed

Make unit tests more nuanced. #69

chihuahua opened this issue Apr 5, 2017 · 0 comments
Labels
v1-archived Issue filed against the deprecated version (V1)

Comments

@chihuahua
Copy link
Collaborator

Today, our unit test is a large, monolithic test that

  1. constructs a graph by passing messages to the panel script and
  2. performs a massive object comparison:

https://github.com/google/audion/blob/master/tests/panel_test.js
This takes the unit out of unit testing. :(

Instead of doing a massive object property comparison, the test should assert for specific details such as the existence of various nodes as well as the specific connections.

Relatedly, we need to test more cases as noted in the TODO within that file. Making the test more concise is a first step that would enable that.

Writing tests is grungy, but important: As we develop more features, we must ensure that we preserve old behavior. I will contribute to this bug and expand test coverage - and anybody else is encouraged to as well.

@hoch hoch added v1-archived Issue filed against the deprecated version (V1) and removed help wanted labels Sep 9, 2021
@hoch hoch closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1-archived Issue filed against the deprecated version (V1)
Projects
None yet
Development

No branches or pull requests

2 participants