Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visualizer] make the graph interactive. (responds to click) #9

Closed
hoch opened this issue Jun 28, 2016 · 4 comments
Closed

[visualizer] make the graph interactive. (responds to click) #9

hoch opened this issue Jun 28, 2016 · 4 comments
Assignees

Comments

@hoch
Copy link
Member

hoch commented Jun 28, 2016

The implementation is here:
https://github.com/hoch/canopy/blob/master/app/spiral-elements/spiral-audiograph/spiral-audiograph.html#L551

Making the dagre graph interactive is quite messy. We might have to find a better way.

@chihuahua
Copy link
Collaborator

Yeah ... come to think, I wonder if we could just assign 1 listener to the 'g' SVG element and check if the target is a node.

@chihuahua chihuahua changed the title [visulaizer] make the graph interactive. (responds to click) [visualizer] make the graph interactive. (responds to click) Jun 29, 2016
@chihuahua chihuahua self-assigned this Jul 6, 2016
@hoch
Copy link
Member Author

hoch commented Jul 11, 2016

Oh, this conflicts with #11 - or it is dependent to the issue at least. I think we can build these 2 features at one PR.

@chihuahua
Copy link
Collaborator

Ay, didn't see this. Yeah, lets do in 1 PR. #29

On Mon, Jul 11, 2016 at 11:31 AM, Hongchan Choi notifications@github.com
wrote:

Oh, this conflicts with #11
#11 - or it is dependent to
the issue at least. I think we can build these 2 features at one PR.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#9 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AEBqcTpqNRiNEJv4N4pljT6eUQ5Dkbzfks5qUov8gaJpZM4JAhAP
.

@hoch
Copy link
Member Author

hoch commented Mar 8, 2017

Since the code base has been changed completely (to goog library) this issue is not relevant any more. Closing.

@hoch hoch closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants