Node version 4 and ES5 support? #8
Comments
|
From @brendankenny on July 18, 2017 17:56 We could explore workarounds for those sticking to earlier versions of Node (suggestions/advice welcome!), but generally the policy is to keep support at the current Node LTS version (currently Node v6). |
|
From @patrickhulce on July 18, 2017 18:39
Any objections to just flipping the target in tsconfig to es5? cc: @samccone |
|
From @brendankenny on July 18, 2017 19:9 oh, good point, just the launcher. The generated code is already pretty ugly, couldn't get much worse :) |
|
From @samccone on July 18, 2017 20:19 we will need to add 4.x to our testing matrix. I am -1 to supporting node version outside of LTS though and would prefer to be inline with lighthouse. |
|
From @bliu23 on August 3, 2017 6:8 That would be great actually. An upgrade to Node 6 is on the drawing board, but we'll definitely need a fix until then. |
|
node v4 is in maintenance until I think for this reason it is reasonable to support this. |
* Fixes * - change tsconfig to target es5 - change tsconfig to include es2015 lib polyfills - change set iteration to use .forEach since this support is not present in es5 - make manual-chrome-launcher not use es2015 import syntax REF #8
* Fixes * - change tsconfig to target es5 - change tsconfig to include es2015 lib polyfills - change set iteration to use .forEach since this support is not present in es5 - make manual-chrome-launcher not use es2015 import syntax REF #8
|
@bliu23 do you still need this? |
|
Whoops, probably should have posted an update but we're fully upgraded to node 6 at this point. Thank though. |
|
all good! closing. |
From @bliu23 on July 18, 2017 16:44
Chrome Launcher does not support Node v4.8.1 nor does it support ES5. Are there plans for this or are there any workarounds for applications written in ES5?
Copied from original issue: GoogleChrome/lighthouse#2708
The text was updated successfully, but these errors were encountered: