Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider merging with @types/chrome #6

Open
schickling opened this issue Jan 7, 2021 · 2 comments
Open

Consider merging with @types/chrome #6

schickling opened this issue Jan 7, 2021 · 2 comments

Comments

@schickling
Copy link

Have you considered merging this project with @types/chrome and using the @types/chrome NPM name going forward? Two benefits:

  • No confusion around "what's the right package to use"
  • TypeScript has some special handling for the @types node_modules folder which it will import automatically. This is perfect for a package like this (similar to @types/node) which also contains global type definitions. This means a user can just yarn add -D @types/chrome and doesn't have to change their tsconfig.json.
@samthor
Copy link
Contributor

samthor commented Apr 30, 2021

We're considering this but haven't looked at how we'd kick it off. We could also create @types/chrome-extensions or something but that would probably just add to developer confusion.

@marcelocra
Copy link

Hey there!

I was looking for chrome typings and wasn't sure which package to use:

  • @types/chrome seems very active and widely used (from npm downloads)
  • this one seems to be created by Google (or Googlers) and seems to generate typings automatically from stable chromium (an advantage, imho)

What's your take on this? Could you kindly add a note to the readme with a suggestion?

(ps: I can imagine that merging the packages would be a lot harder than adding a note. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants