Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop first video when second video starts playing #184

Closed
felipebochehin87 opened this issue Feb 4, 2022 · 2 comments
Closed

Stop first video when second video starts playing #184

felipebochehin87 opened this issue Feb 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@felipebochehin87
Copy link

Feature description

We currently allow two videos being played at the same time (one in PiP, another one in the regular view). I kindly suggest stopping the first video (even if this is in PiP) when the second video starts playing.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Stop the first video (even if this is in PiP) when the second video starts playing.

Implementation brief

QA testing instructions

  1. Start playing a video
  2. Move it to PiP
  3. Go back to home
  4. Start playing another video

Demo

Changelog entry

@felipebochehin87 felipebochehin87 added the enhancement New feature or request label Feb 4, 2022
@dero
Copy link
Collaborator

dero commented Feb 4, 2022

@felipebochehin87 I considered that during development – and I personally think the application should not presume the user only wants to watch one playing video at a time.

Two reasons for that:

  1. I can think of many use cases for having two videos playing at the same time: one in PiP and the other on a page. Imagine there is a live broadcast of a soccer game. I'm waiting for a match to start, so I keep that stream playing muted in PiP and just check it from time to time while watching another video as my main content while I'm waiting.
  2. For learning purposes, I think it's useful for any developers to be able to test out and see that PiP video can play alongside any other video on a web page.

@dero
Copy link
Collaborator

dero commented Feb 4, 2022

Chatted with @felipebochehin87 and we decided to close this issue.

@dero dero closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants