docs(error-reporting): improve clarity for opt-out folks #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
reviewed
Nov 21, 2017
lighthouse-cli/cli-flags.js
Outdated
| @@ -59,7 +59,7 @@ function getFlags(manualArgv) { | |||
| 'Configuration:') | |||
| .describe({ | |||
| 'enable-error-reporting': | |||
| 'Enables error reporting (prompts once by default, setting this flag will force error reporting to that state).', | |||
| 'Force enables error reporting. --no-enable-error-reporting will force disable. More: https://git.io/vFFTO', | |||
There was a problem hiding this comment.
"Force enables" sounds like a Jedi move. How about "Enables error reporting, overriding any saved preference...."
There was a problem hiding this comment.
Enables error reporting, overriding any saved preference. --no-enable-error-reporting will do the opposite. More: https://git.io/vFFTO
ebidel
approved these changes
Nov 21, 2017
|
should we never prompt again or after x weeks or after each new release? |
I'm into the idea of prompting again if we hit that 20sec timeout, but also it may not matter with enough scale. |
patrickhulce
approved these changes
Nov 21, 2017
|
Should we ship a quick 2.6.1 with this and Brendans new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3854