report: more attractive table/URL rendering #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
reviewed
Jan 8, 2018
| element.appendChild(this._renderText({ | ||
| text: displayedPath, | ||
| })); | ||
| const hostElem = this._renderText({ |
There was a problem hiding this comment.
does this need to be conditional on displayedHost?
| @@ -147,8 +147,15 @@ class Util { | |||
| } | |||
|
|
|||
| const MAX_LENGTH = 64; | |||
| // Always elide hash | |||
| // Always elide git hash | |||
There was a problem hiding this comment.
how about just hex hash :)
| // Also elide long number sequences | ||
| name = name.replace(/(\d{3})\d{6,}/g, `$1${ELLIPSIS}`); | ||
| // Merge any adjacent ellipses | ||
| name = name.replace(/\u2026+/g, '\u2026'); |
There was a problem hiding this comment.
\u2026 is ellipsis right, so just pass ELLIPSIS here like the others? :)
paulirish
force-pushed
the
bettertables
branch
from
c66a63b
to
c54014a
Compare
good call!! it wasn't ideal. but after some fixes:
updated. |
|
awaiting CI results. when green, land away. |
|
geez since when did "Unable to connect to Chrome" start failing 100% of the time?? |
This was referenced Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before and after
partial fix for #3827 but its not totally complete.