Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(travis): force use of GCE, remove dSE calls #4222

Merged
merged 11 commits into from
Jan 10, 2018
Merged

tests(travis): force use of GCE, remove dSE calls #4222

merged 11 commits into from
Jan 10, 2018

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Jan 9, 2018 •
edited
Loading

make 💡 🏠 💚 again

closes #4221 due to travis-ci/travis-ci#8836

@patrickhulce patrickhulce changed the title tests(travis): force use of sudo tests(travis): force use of GCE Jan 9, 2018
@paulirish
Copy link
Member

looks good so far.
image

paulirish
paulirish reviewed Jan 9, 2018
View reviewed changes
lighthouse-core/test/lib/asset-saver-test.js Outdated
fs.unlinkSync(traceFilename);
});
}).timeout(120000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to https://travis-ci.org/GoogleChrome/lighthouse/jobs/327029200#L1499 the forEach takes just 160ms.

so we can nuke this timeout.

@GoogleChrome GoogleChrome deleted a comment from googlebot Jan 9, 2018
@GoogleChrome GoogleChrome deleted a comment from googlebot Jan 9, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@patrickhulce patrickhulce changed the title tests(travis): force use of GCE tests(travis): force use of GCE, remove dSE calls Jan 10, 2018
@patrickhulce
Copy link
Collaborator Author

huzzah!!
image

@patrickhulce patrickhulce merged commit e1cab8f into master Jan 10, 2018
@patrickhulce patrickhulce deleted the travis_fixing branch January 10, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing travis builds
5 participants
@patrickhulce @paulirish @googlebot @Bluewolf1457 @devtools-bot