docs(headless-chrome): switch to prioritize headless #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
suggested changes
Feb 15, 2018
docs/headless-chrome.md
Outdated
| For now, we recommend running Chrome with xvfb. See below. | ||
| ## CLI (headless) | ||
|
|
||
| > **Note**: Headless Chrome still has a few bugs to work out. For example, [network emulation](https://bugs.chromium.org/p/chromium/issues/detail?id=728451) is not supported yet. |
There was a problem hiding this comment.
can we remove this caveat now? :D
might be worth still noting there may be some graphics-related perf differences
There was a problem hiding this comment.
👍 . offline and throttling are implemented. we can nuke the note.
there should probably be a list somewhere which documents known differences between headless and headful. but there isn't one yet.
docs/headless-chrome.md
Outdated
|
|
||
| ## CLI (xvfb) | ||
|
|
||
| Chrome + xvfb is the stable solution we recommend. These steps worked on Debian Jessie: | ||
| Alternativeluy, you can run full Chrome + xvfb instead of headless mode. These steps worked on Debian Jessie: |
There was a problem hiding this comment.
s/Alternativeluy/Alternatively
|
ready to go |
patrickhulce
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritizing headless now that it supports emulation.