core(runner): rename generatedTime to fetchedAt #4783
Conversation
evenstensberg
requested review from
brendankenny,
ebidel,
patrickhulce,
paulirish and
vinamratasingal-zz
as code owners
| .then(_ => driver.getUserAgent()) | ||
| .then(_ => { | ||
| options.fetchedAt = (new Date()).toJSON(); | ||
| return driver.getUserAgent(); |
There was a problem hiding this comment.
The other promise expects the user agent in return, throws else. Can convert to one-liner if you want to.
|
Looks like the Chrome Infra is using generatedTime, should I change that? |
There was a problem hiding this comment.
thanks for taking this on @ev1stensberg!
we'll have quite a bit to clean up at the same time when we roll LH to Chrome, so no need for any changes there yet. I've updated #4333 to make sure we don't lose track of this one :)
| @@ -100,7 +100,10 @@ class GatherRunner { | |||
| const resetStorage = !options.flags.disableStorageReset; | |||
| // Enable emulation based on flags | |||
| return driver.assertNoSameOriginServiceWorkerClients(options.url) | |||
| .then(_ => driver.getUserAgent()) | |||
| .then(_ => { | |||
| options.fetchedAt = (new Date()).toJSON(); | |||
There was a problem hiding this comment.
think we can stick it on gathererResults instead like we do for user agent?
There was a problem hiding this comment.
It's gonna be an artifact though? Replaced with gatherRunner and when running the tests ( 2 failed ), this is what came up:
Lighthouse has result.fetchedAt as a prop above the artifact, but it resolves to undefined
There was a problem hiding this comment.
it makes a little more semantic sense to have it as an artifact like UserAgent as it is produced through the gathering process. also I think we'll have to to get this to work with the lighthouse -G && lighthouse -A workflow that paul flagged as part of #4753 since we don't save options to disk, just artifacts
There was a problem hiding this comment.
it might need some updating of tests as you noticed though :) sorry!
There was a problem hiding this comment.
Makes sense now as you say it, a bit busy now, but going to address it during the weekend 👍
|
Also, noticed you're replacing Nexus in favor for Pixel in emulation. Could I take a crack at that? |
I think that proposal needs a little more discussion before we move to impl ;) love the enthusiasm though! |
| @@ -348,6 +351,7 @@ class GatherRunner { | |||
| // Nest LighthouseRunWarnings, if any, so they will be collected into artifact. | |||
| const uniqueWarnings = Array.from(new Set(gathererResults.LighthouseRunWarnings)); | |||
| gathererResults.LighthouseRunWarnings = [uniqueWarnings]; | |||
| gathererResults.fetchedAt = [gathererResults.fetchedAt]; | |||
There was a problem hiding this comment.
Works now, sorry for delaying. Extremely hungover yesterday 😄
There was a problem hiding this comment.
Another thing, if people use this through the CLI, do we need to expose name etc in order to save it to disk using -A or -G?
patrickhulce
changed the title
Fixes #4753
Summary
Refactored some code to fit the new convention.
fetchedAtgets mounted to the options object and pulled in the runner. Default value/fallback is set in the formatter, so no need to set default value on an empty Date object (doesn't ever resolve to null either).Ping me if there's anything that needs to be revised.