report: eliminate cards and list details #4789
Conversation
patrickhulce
requested review from
brendankenny,
paulirish and
vinamratasingal-zz
as code owners
| const items = [ | ||
| { | ||
| totalNodes: Util.formatNumber(stats.totalDOMNodes), | ||
| depth: `${Util.formatNumber(stats.depth.max)} (${depthSnippet})`, |
There was a problem hiding this comment.
i dont know if this display will scale.
e.g:
fwiw here is the same with the card:
url is https://tinyhousebuild.com/ btw
There was a problem hiding this comment.
heh good catch, do we really need the snippet displayed if it was just a tooltip before?
just saw below I like outer HTML 👍
| }]; | ||
| const headings = [ | ||
| {key: 'totalNodes', itemType: 'text', text: 'Total DOM Nodes'}, | ||
| {key: 'depth', itemType: 'text', text: 'DOM Depth'}, |
There was a problem hiding this comment.
let's add "Maximum" to this title
| const widthSnippet = 'Element with most children:\n' + | ||
| stats.width.pathToElement[stats.width.pathToElement.length - 1]; | ||
| const depthSnippet = stats.depth.pathToElement.join(' > '); | ||
| const widthSnippet = stats.width.pathToElement.join(' > '); |
There was a problem hiding this comment.
for the snippet i think we could simplify by providing the outerhtml snippet like
lighthouse/lighthouse-core/gather/gatherers/accessibility.js
Lines 76 to 85 in 7c7695b
and forget this selector thing that will never scale.
i dont think this SOLVES the scaling problem, but it helps. maybe we put these snippets on a new row?
There was a problem hiding this comment.
yeah agreed this is better 👍 I think we solve this with a new type in fancy report land with the other page stats (# network requests, etc)
There was a problem hiding this comment.
I tried to get fancy and make it a proper node type but that looks a bit wonky as they get left-aligned while text right-aligned
There was a problem hiding this comment.
here's it as text which is what I'm going with for now, I expect this to change before 3.0 anyhow
|
|
||
| node lighthouse-cli/test/fixtures/static-server.js & | ||
|
|
||
| node lighthouse-cli/index.js --output=json http://localhost:10200/dobetterweb/dbw_tester.html > ./lighthouse-core/test/results/sample_v2.json |
There was a problem hiding this comment.
i'd recommend using --output_path instead. it will help avoid any logging ending up there.
also with > the file is cleared the second this command starts, whereas with output_path it's just changed when everything is done.
| @@ -0,0 +1,13 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
I was thinking of checking in the latest-run artifacts folder for this fixture. so we'd have 1 script to run -A against it... and a second to refresh the artifacts. hows that sound?
There was a problem hiding this comment.
so if I understand your proposal, is it two scripts
scripts/run-dash-a-against-dbw.sh
and
scripts/update-fixtures-with-latest-artifacts.sh
names pending? :) that sounds fine but not sure why we would necessarily need both. Is there a use case for running just the first?
|
is this waiting on #4793? |
yeah let's land that first. then we can nuke the .sh file from here and rebase. will be a superclean sample json diff :) |
|
much smaller diff now 👌 one more look? |
in the name of #4333
replaces them with tables for now
I think it's actually somewhat of an improvement for list ones :)