core(img-usage): handle invalid images within determineNaturalSize #4812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Mar 19, 2018
There was a problem hiding this comment.
The Sentry link is for Error: unknown error but seems like we might just be trading this out for Invalid image sizing information, no?
lighthouse/lighthouse-core/audits/image-aspect-ratio.js
Lines 43 to 46 in 0cddcd3
Change seems like an improvement either way 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://sentry.io/google-lighthouse/lighthouse/issues/407848291/.. our 4th most common error!
It's reproducible on https://www.habitatetjardin.com/ with this image (https://i.habitatetjardin.com/images/bandefin_jardin.gif), though there's probably another URL that's a tad more minimal.