Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(extension): add reminder about building the extension #4902

Merged
merged 1 commit into from
Mar 30, 2018
Merged

tests(extension): add reminder about building the extension #4902

merged 1 commit into from
Mar 30, 2018

Conversation

paulirish
Copy link
Member

No description provided.

@paulirish paulirish removed the request for review from patrickhulce March 30, 2018 21:41
brendankenny
brendankenny approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be cool if mocha had some sort of afterError lifecycle function to print this in just that case, but I don't see one

@paulirish paulirish merged commit 216eccf into master Mar 30, 2018
@paulirish paulirish deleted the thisisnotgoingdirecttomaster branch March 30, 2018 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulirish @brendankenny @patrickhulce @devtools-bot