core(tsc): add types for DevtoolsLog and NetworkRecorder #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Apr 4, 2018
patrickhulce
reviewed
Apr 4, 2018
typings/externs.d.ts
Outdated
| args: any; | ||
| args: { | ||
| data?: { | ||
| url: string |
There was a problem hiding this comment.
this is an optional property, url?: string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
easy change to add types to
DevtoolsLogandNetworkRecordersince we already have all the crdp event types.Moved @patrickhulce's existing work on
NetworkRequestto aLH.WebInspectornamespace (since that's how we've nested it in our not-actually-type-checking past) and added the additional properties we needed to the interface.We can probably continue to add properties as we go (seems ok?), though we do need to be careful about optional properties on the interface because the state we deal with these requests (after passing through NetworkRecorder which requires the full request lifecycle) is quite different than the initial constructed object which has many uninitialized properties (and even more added later but not initialized in the constructor :S)
Also did a quick
s/WebInspector.NetworkRequest/LH.WebInspector.NetworkRequestparams replacement elsewhere so that they'll be correct when we turn on type checking for all those files.