core(metrics): move TTCI to computed artifact #4943

patrickhulce · 2018-04-09T17:05:38Z

progress toward #4872, starting with just one to make sure we like how it looks. will follow up with others if this looks good

review timer according to #4934 has this deadline at 4/10 10:05am :)

brendankenny

I'm liking this approach to automating requests for simulated vs observed metrics. So far mostly just questions about where that abstraction should be invoked

brendankenny · 2018-04-09T22:53:29Z

lighthouse-core/gather/computed/metrics/metric.js

+
+const ComputedArtifact = require('../computed-artifact');
+
+class MetricArtifact extends ComputedArtifact {


bikeshed: I don't want to suggest ComputedMetricArtifact :) but maybe ComputedMetric is better here?

brendankenny · 2018-04-09T22:54:50Z

lighthouse-core/gather/computed/metrics/metric.js

+
+  /**
+   * @param {LH.Gatherer.Artifact.MetricComputationData} data
+   * @param {Object} artifacts


if we land after #4944 these can become LH.Artifacts...the only downside is that there would need to be changes in a bunch of other places too :)

🏁 -------- 🐎 💨
🏁 ---- 🐎 💨

brendankenny · 2018-04-09T23:03:41Z

lighthouse-core/gather/computed/metrics/metric.js

+  }
+
+  /**
+   * @param {LH.Gatherer.Artifact.MetricComputationData} data


are there benefits to doing this on the behalf of the computed artifact instead of having them do it? It makes sense now, I'm just wondering if it's going to grow over time to include so many other artifacts that data and artifacts will start to be the same thing :)

This does allow them to select which pass's data to work on, but the pass name could be part of data instead, I guess. Not sure of other benefits...

The primary benefits:

All callers of compute* should pass in the same set of properties to ensure that caching works since it's based on deep equality (maybe we should split this into separate typedef?)

Achieve 1 while still allowing one-off computations for alternative settings, for example, regardless of the throttling specified, load-fast-enough-4-pwa will always use lantern to compute the 10s TTI for consistency (and enable the audit to not stick the ugly toplevel warning when called without DT throttling)

All artifacts would need to do the networkRecords traceOfTab as their first two lines

brendankenny · 2018-04-09T23:06:10Z

lighthouse-core/gather/computed/metrics/consistently-interactive.js

+   * number of allowed concurrent requests (2).
+   * @param {Array<LH.WebInspector.NetworkRequest>} networkRecords
+   * @param {{timestamps: {traceEnd: number}}} traceOfTab
+   * @return {!Array<!TimePeriod>}


delete all these !s :)

brendankenny · 2018-04-09T23:08:04Z

lighthouse-core/gather/computed/metrics/metric.js

+
+const ComputedArtifact = require('../computed-artifact');
+
+class MetricArtifact extends ComputedArtifact {


a class-level doc string would be good too, just to give a sense that this is for computed artifacts calculating metrics, supporting simulated and observed. To implement, override these methods...

brendankenny · 2018-04-09T23:09:25Z

lighthouse-core/gather/computed/metrics/consistently-interactive.js

+  static findOverlappingQuietPeriods(longTasks, networkRecords, traceOfTab) {
+    const FMPTsInMs = traceOfTab.timestamps.firstMeaningfulPaint / 1000;
+
+    /** @type {function(TimePeriod):boolean} */


you should be able to get away with just /** @param {TimePeriod} period */ (or you might prefer the current form :)

meh I like the explicitness of this one if I'm gonna bother with the typedef anyhow :)

brendankenny · 2018-04-09T23:16:03Z

lighthouse-core/gather/computed/metrics/metric.js

+   * @return {Promise<LH.Gatherer.Artifact.LanternMetric>}
+   */
+  computeSimulatedMetric(data, artifacts) {
+    return artifacts[`requestLantern${this.name}`](data);


this is kind of unfortunate, though I don't know a great way around it besides making computed metrics copy and paste basically this line. Benefits would be easier typing (more useful if lantern metrics wanted to start returning metric-specific details) and computed artifacts could do things like alter and combine simulated results, but it would be kind of ugly in the default case

how about we turn this into an unimplemented method the first case we have that needs either of those? :)

lol fair but I'm holding you to it :P

paulirish · 2018-04-09T23:18:46Z

lighthouse-core/audits/consistently-interactive.js

-          traceOfTab.timestamps.domContentLoaded / 1000
-        ) * 1000;
-        const timeInMs = (timestamp - traceOfTab.timestamps.navigationStart) / 1000;
-        const extendedInfo = Object.assign(quietPeriodInfo, {timestamp, timeInMs});


just to call out, this PR does remove quietPeriodInfo from the extInfo, but i think that's just fine. ;)

patrickhulce · 2018-04-10T15:54:41Z

aight @brendankenny all rebased, are we GTG?

brendankenny

LGTM!

will follow up with others if this looks good

if possible, can we do one at a time? Fine if in parallel, though. Presumably more annoying for you, but I think reviewing will go a lot quicker (especially now that this lands the base classes) assuming the regular review thoroughness :)

patrickhulce added 2 commits April 9, 2018 09:21

core(metrics): move TTCI to computed artifact

388d5bc

typecheck and whatnot

5ddaba7

patrickhulce added the I/O-Expedite label Apr 9, 2018

patrickhulce requested review from brendankenny and paulirish as code owners April 9, 2018 17:05

devtools-bot added the waiting4reviewer label Apr 9, 2018

brendankenny requested changes Apr 9, 2018

View reviewed changes

paulirish approved these changes Apr 9, 2018

View reviewed changes

patrickhulce added 4 commits April 9, 2018 16:49

feedback

f1f2a78

remove gatherer.d.ts changes for rebase

6711aea

Merge branch 'master' into tti_computed_art

c61dcb6

rebase changes

455ef92

brendankenny approved these changes Apr 10, 2018

View reviewed changes

patrickhulce merged commit fe07970 into master Apr 10, 2018

patrickhulce deleted the tti_computed_art branch April 10, 2018 18:10

paulirish removed the waiting4reviewer label Apr 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core(metrics): move TTCI to computed artifact #4943

core(metrics): move TTCI to computed artifact #4943

patrickhulce commented Apr 9, 2018 •

edited

Loading

brendankenny left a comment

brendankenny Apr 9, 2018

patrickhulce Apr 9, 2018

brendankenny Apr 9, 2018

patrickhulce Apr 9, 2018 •

edited

Loading

brendankenny Apr 9, 2018

patrickhulce Apr 9, 2018

brendankenny Apr 9, 2018

patrickhulce Apr 9, 2018

brendankenny Apr 9, 2018

patrickhulce Apr 9, 2018

brendankenny Apr 9, 2018

patrickhulce Apr 10, 2018

brendankenny Apr 9, 2018

patrickhulce Apr 9, 2018

brendankenny Apr 10, 2018

paulirish Apr 9, 2018

patrickhulce commented Apr 10, 2018

brendankenny left a comment


		const ComputedArtifact = require('../computed-artifact');

		class MetricArtifact extends ComputedArtifact {

core(metrics): move TTCI to computed artifact #4943

core(metrics): move TTCI to computed artifact #4943

Conversation

patrickhulce commented Apr 9, 2018 • edited Loading

brendankenny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patrickhulce Apr 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patrickhulce commented Apr 10, 2018

brendankenny left a comment

Choose a reason for hiding this comment

patrickhulce commented Apr 9, 2018 •

edited

Loading

patrickhulce Apr 9, 2018 •

edited

Loading