core(lhr): convert reportCategories to categories object #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
paulirish and
vinamratasingal-zz
as code owners
patrickhulce
force-pushed
the
categories_groups
branch
from
e5c287e
to
40adda9
Compare
brendankenny
approved these changes
May 8, 2018
lighthouse-core/runner.js
Outdated
| if (opts.config.categories) { | ||
| reportCategories = ReportScoring.scoreAllCategories(opts.config.categories, resultsById); | ||
| categories = ReportScoring.scoreAllCategories(opts.config.categories, resultsById); | ||
| } | ||
|
|
||
| const lhr = { |
There was a problem hiding this comment.
we should probably put a /** @type {LH.Result} */ above this so it's checked for excess properties not in the def (reportGroups -> categoryGroups isn't caught by the un-updated type in lhr.d.ts since reportGroups was optional)
There was a problem hiding this comment.
yeah good call done
typings/lhr.d.ts
Outdated
| @@ -21,7 +21,7 @@ declare global { | |||
| /** An object containing the results of the audits, keyed by the audits' `id` identifier. */ | |||
| audits: Record<string, Audit.Result>; | |||
| /** The top-level categories, their overall scores, and member audits. */ | |||
| reportCategories: Result.Category[]; | |||
| categories: Record<string, Result.Category>; | |||
| /** Descriptions of the groups referenced by CategoryMembers. */ | |||
| reportGroups?: Record<string, Result.Group>; | |||
There was a problem hiding this comment.
and do we want the interface of the values to be ReportGroup to match our usual plural/singular thing?
There was a problem hiding this comment.
yeah good call fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #4333 #5008