core(lhr): s/audits/auditRefs, s/category.name/category.title/ #5157
Conversation
patrickhulce
requested review from
brendankenny,
ebidel,
paulirish and
vinamratasingal-zz
as code owners
typings/lhr.d.ts
Outdated
| /** A more detailed description of the category and its importance. */ | ||
| description?: string; | ||
| /** A description for the manual audits in the category. */ | ||
| manualDescription?: string; | ||
| /** The overall score of the category, the weighted average of all its audits. */ | ||
| score: number|null; | ||
| /** An array of references to all the audit members of this category. */ | ||
| audits: CategoryMember[]; | ||
| auditRefs: CategoryMember[]; | ||
| } | ||
|
|
||
| export interface CategoryMember { |
typings/config.d.ts
Outdated
| @@ -103,7 +103,7 @@ declare global { | |||
| // TODO: For now, these are unchanged from JSON and Result versions. Need to harmonize. | |||
| export interface CategoryMember extends CategoryMemberJson {} | |||
| export interface Category extends CategoryJson { | |||
| audits: CategoryMember[]; | |||
There was a problem hiding this comment.
auditRef/auditRefJson up here too
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
ref #4333 #5008