core(uses-preload): prevent infinite loop #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
May 11, 2018
| * @return {boolean} | ||
| */ | ||
| static hasCycle(node) { | ||
| static hasCycle(node, direction = 'all') { | ||
| if (direction === 'all') { |
There was a problem hiding this comment.
it seems like the only use we have of this method checks things with the root node, implying we only care about one direction. Maybe we just rename this to hasCycleInDependents until we need the other direction?
There was a problem hiding this comment.
wait, isn't it always checking both? Why have an option at all
There was a problem hiding this comment.
discussed in person, I'll add a comment here
| const nodesToExplore = direction === 'dependents' ? | ||
| currentNode._dependents : | ||
| currentNode._dependencies; | ||
| for (const dependent of nodesToExplore) { |
There was a problem hiding this comment.
call it nextNode or something? Confusing to flatten like that
| * @return {boolean} | ||
| */ | ||
| static hasCycle(node) { | ||
| static hasCycle(node, direction = 'all') { | ||
| if (direction === 'all') { |
There was a problem hiding this comment.
wait, isn't it always checking both? Why have an option at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an infinite loop on https://emojityper.com/
attacked from multiple prongs: