tests(compile): fix broken compile-devtools script

[paulirish]

fwiw here's the current output:

Compiling frontend...
Compiling devtools_compatibility.js...
Verifying JSDoc comments...
/Users/paulirish/code/lighthouse/node_modules/lh-compile-devtools/two-more/almost-there/temp-devtoolsfrontend/front_end/audits2/lighthouse/renderer/util.js:35: ERROR - Type "Array" nullability not marked explicitly with "?" (nullable) or "!" (non-nullable)
   * @param {string|Array<string|number>=} displayValue
                    ^

/Users/paulirish/code/lighthouse/node_modules/lh-compile-devtools/two-more/almost-there/temp-devtoolsfrontend/front_end/audits2/lighthouse/renderer/util.js:313: ERROR - Type "LH.Config.Settings" nullability not marked explicitly with "?" (nullable) or "!" (non-nullable)
   * @param {LH.Config.Settings} settings
             ^

/Users/paulirish/code/lighthouse/node_modules/lh-compile-devtools/two-more/almost-there/temp-devtoolsfrontend/front_end/audits2/lighthouse/renderer/util.js:314: ERROR - Type "Array" nullability not marked explicitly with "?" (nullable) or "!" (non-nullable)
   * @return {Array<{name: string, description: string}>}
              ^

/Users/paulirish/code/lighthouse/node_modules/lh-compile-devtools/two-more/almost-there/temp-devtoolsfrontend/front_end/audits2/lighthouse/renderer/util.js:336: ERROR - Type "LH.Config.Settings" nullability not marked explicitly with "?" (nullable) or "!" (non-nullable)
   * @param {LH.Config.Settings} settings
             ^

devtools_compatibility.js compilation output:
0 error(s), 0 warning(s), 95.6% typed

devtools frontend compilation output:
/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/Audits2Panel.js:284: WARNING - property _renderReportNav not defined on any superclass of Audits2.Audits2Panel.ReportRenderer
  _renderReportNav() {
  ^^^^^^^^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/Audits2Panel.js:490: WARNING - Property generatedTime never defined on lighthouseResult
    const timestamp = lighthouseResult.generatedTime;
                                       ^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/Audits2Panel.js:514: WARNING - Property generatedTime never defined on Audits2.ReportSelector.Item._lighthouseResult
    const timestamp = this._lighthouseResult.generatedTime;
                                             ^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/Audits2Panel.js:570: WARNING - property renderPerformanceCategory not defined on any superclass of Audits2.CategoryRenderer
  renderPerformanceCategory(category, groups) {
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/report-renderer.js:256: WARNING - Bad type annotation. Unknown type LH.Config.Settings
 *     configSettings: !LH.Config.Settings,
                        ^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:313: WARNING - Bad type annotation. Unknown type LH.Config.Settings
   * @param {LH.Config.Settings} settings
             ^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:336: WARNING - Bad type annotation. Unknown type LH.Config.Settings
   * @param {LH.Config.Settings} settings
             ^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:351: WARNING - Property cpuSlowdownMultiplier never defined on $jscomp$destructuring$var16
        const {cpuSlowdownMultiplier, requestLatencyMs} = throttling;
               ^^^^^^^^^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:351: WARNING - Property requestLatencyMs never defined on $jscomp$destructuring$var16
        const {cpuSlowdownMultiplier, requestLatencyMs} = throttling;
                                      ^^^^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:354: WARNING - Property downloadThroughputKbps never defined on throttling
          `${Util.formatNumber(throttling.downloadThroughputKbps)}${NBSP}Kbps down, ` +
                                          ^^^^^^^^^^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:355: WARNING - Property uploadThroughputKbps never defined on throttling
          `${Util.formatNumber(throttling.uploadThroughputKbps)}${NBSP}Kbps up (DevTools)`;
                                          ^^^^^^^^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:359: WARNING - Property cpuSlowdownMultiplier never defined on $jscomp$destructuring$var17
        const {cpuSlowdownMultiplier, rttMs, throughputKbps} = throttling;
               ^^^^^^^^^^^^^^^^^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:359: WARNING - Property rttMs never defined on $jscomp$destructuring$var17
        const {cpuSlowdownMultiplier, rttMs, throughputKbps} = throttling;
                                      ^^^^^

/var/folders/8n/wjngz5hs11ngfp52_chqvzxh003dq2/T/tmpbnXu4d/front_end/audits2/lighthouse/renderer/util.js:359: WARNING - Property throughputKbps never defined on $jscomp$destructuring$var17
        const {cpuSlowdownMultiplier, rttMs, throughputKbps} = throttling;
                                             ^^^^^^^^^^^^^^

0 error(s), 14 warning(s), 94.3% typed

ERRORS DETECTED
error Command failed with exit code 1.

[brendankenny]

nice!

[patrickhulce]

🆒 🆒 🆒