Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(opportunities): more granular score #5331

Merged
merged 2 commits into from
May 31, 2018
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
Introduces more granular opportunity scores based on the same old control points as before (but now with linear interpolation). Would help with doing summaries of the performance category and many people are confused by the limited score choices.

Users not consuming the JSON should be entirely unaffected by this change.

cc @rviscomi

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM and having a continuous score makes sense to me, at least.

Looks like a smoke expectation will need to be updated, though

@patrickhulce patrickhulce merged commit a7710ef into master May 31, 2018
@patrickhulce patrickhulce deleted the granular_opp_scores branch May 31, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants