core(image-aspect-ratio): loosen ratio check #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const doRatiosMatch = Math.abs(actualAspectRatio - displayedAspectRatio) < THRESHOLD; | ||
|
|
||
| const targetDisplayHeight = image.width / actualAspectRatio; | ||
| const doRatiosMatch = Math.abs(actualAspectRatio - displayedAspectRatio) < THRESHOLD_PERCENT || |
There was a problem hiding this comment.
is there value in maintaining the ratio difference check, then? It seems like it would either be less lenient than the pixel check or the images would be big enough that they would have the flexibility to change the image size to get under the limit.
I haven't completely worked out the problem, though, so I may be missing cases :)
There was a problem hiding this comment.
a quick check with this branch shows that dropping it for the pixel check would still pass all our tests, at least :)
There was a problem hiding this comment.
yeah sgtm, let's just go with targetDisplayHeight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
closes #5356