core(preload): remove blob protocol from preload audit #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
patrickhulce
reviewed
Jun 4, 2018
| @@ -196,6 +196,36 @@ describe('Performance: uses-rel-preload audit', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it(`shouldn't suggest preload for protocol blob`, () => { | |||
There was a problem hiding this comment.
does this test fail without the fix? seems like it wouldn't have wastedMs anyhow
There was a problem hiding this comment.
maybe let's just leave a TODO to make creating fake lantern graphs easier, it's inline with the other tests in the file for now
paulirish
requested changes
Jun 7, 2018
| @@ -159,7 +159,8 @@ class UsesRelPreloadAudit extends Audit { | |||
| /** @type {Set<string>} */ | |||
| const urls = new Set(); | |||
| for (const networkRecord of criticalRequests) { | |||
| if (!networkRecord._isLinkPreload && networkRecord.protocol !== 'data') { | |||
| if (!networkRecord._isLinkPreload && networkRecord.protocol !== 'data' | |||
There was a problem hiding this comment.
can we move this to an array in url-shim?
NON_NETWORK_PROTOCOLS or something?
There's a few audits where we're checking these individually and i think we can generalize it.
wardpeet
force-pushed
the
bug/preload-blob-video
branch
from
8ee0e61
to
0056e7a
Compare
paulirish
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the blob protocol of preload requests like we do for data
Related Issues/PRs
Fixes #5380