Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update required chrome version #5425

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Conversation

patrickhulce
Copy link
Collaborator

#5424 got me thinkin' :)

@paulirish
Copy link
Member

i wonder if we should just point to https://googlechromelabs.github.io/current-versions/ and say "stable"

@patrickhulce
Copy link
Collaborator Author

Meh, I'm somewhat ambivalent. We don't really need to update it that often, but it is a pain to remember.

@paulirish
Copy link
Member

sure.

related:
#5424 looks like it was with Chromium 65, which is recent enough to not have headless issues, id expect.
so i dont know if a bump to 66 really woulda solved it for him

@patrickhulce
Copy link
Collaborator Author

#5424 got me thinking not because it had anything to do with his problem but because the bug contained the error message "The environment variable CHROME_PATH must be set to executable of a build of Chromium version 54.0 or later" which is definitely wrong at this point.

@paulirish paulirish merged commit ee0c35a into master Jun 11, 2018
@paulirish paulirish deleted the update_chrome_version branch June 11, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants