core: convert gather-runner.js to async/await #5462
Conversation
| const pass = Promise.resolve() | ||
| // Clear disk & memory cache if it's a perf run | ||
| .then(_ => { | ||
| if (isPerfRun) driver.cleanBrowserCaches(); |
There was a problem hiding this comment.
this code wasn't be awaited, but it looks like it should be. Same with beginTrace down below.
There was a problem hiding this comment.
whoops :( Good catch.
I wonder if there's a lint rule that checks if promises like this are eventually awaited/resolved. Would be easier with type information with tslint, but seems like you could reason about it entirely locally (caller's responsibility if it's returned)
There was a problem hiding this comment.
maybe https://palantir.github.io/tslint/rules/no-floating-promises/, which isn't perfect but would have caught this
There was a problem hiding this comment.
I think just using async/await makes these stand out a lot more. That lint rule might be more trouble than its worth.
|
|
||
| // Navigate. | ||
| await GatherRunner.loadPage(driver, passContext); | ||
| await log.log('statusEnd', status); |
There was a problem hiding this comment.
this one shouldn't need to be awaited
I was reading through how this file worked, and decided to convert it to async/await as I did. Clears up some dastardly uses of
array.reduce.