Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(fcp): fix scoring curve #5507

Merged
merged 1 commit into from
Jun 19, 2018
Merged

core(fcp): fix scoring curve #5507

merged 1 commit into from
Jun 19, 2018

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Jun 15, 2018

so slightly embarrassing here, but somehow in the shuffle of metric scoring curves I updated FCP to the wrong value. the calculator spreadsheet, desmos curve, HTTPArchive, and logic from the PODR of FMP all dictate that the FCP one should be 2000, but it's 2900 (like TTI). Oops 馃槥

good thing it's still the beta release 馃槅

tag #5092

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny brendankenny merged commit 0deeeb5 into master Jun 19, 2018
@paulirish paulirish deleted the fix_fcp_score branch January 11, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants