Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(architecture): add diagram of module dependencies #5615

Merged
merged 1 commit into from
Jul 3, 2018
Merged

docs(architecture): add diagram of module dependencies #5615

merged 1 commit into from
Jul 3, 2018

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Jul 3, 2018 •
edited
Loading

No description provided.

patrickhulce
patrickhulce approved these changes Jul 3, 2018
View reviewed changes
docs/architecture.md

## Lighthouse-core internal module dependencies

![image](https://user-images.githubusercontent.com/39191/42241426-609d15f6-7ebf-11e8-9e40-411d9ede43e6.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooooooo, pretty :)

brendankenny
brendankenny approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! (those arrows going backwards though...)

@paulirish paulirish merged commit 94d0431 into master Jul 3, 2018
@paulirish paulirish deleted the paulirish-patch-2 branch July 3, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulirish @brendankenny @patrickhulce