misc(typings): convert hardcoded strings to networkRequests.TYPES

[wardpeet]

Summary
Just fixing some changes we missed for resourceType

Related Issues/PRs

[wardpeet]

I stumbled upon some other hardcoded strings I'm not sure if they are intentional or not so just checking if I need to change them too.

estimateTransferSize in the byte-efficiency-audits we call resourceType as a string not sure if we should move to NetworkRecord.TYPES too.

which means
const totalBytes = ByteEfficiencyAudit.estimateTransferSize(networkRecord, contentLength, 'Script');
becomes

const totalBytes = ByteEfficiencyAudit.estimateTransferSize(networkRecord, contentLength, NetworkRequest.TYPES.Script');

[brendankenny]

Since they're equivalent (the enum value is just that string) and both approaches (enum vs raw string) are now correctly type-checked, I personally don't really care which is used.

Sometimes the enum seems way too verbose, sometimes it adds clarity ("I'm specifying a resource type, not just a random string"), so I'm personally in favor of leaving it as the original author wrote it unless one advantage seems to strongly outweigh the other in a specific use.

meant to be a comment, not an approval :)

[patrickhulce]

I too have almost no preference here, so I'm good with whatever. With type checking it makes little difference to me. Bringing in the enum is another require but can make it a bit more explicit where the value is coming from.

[patrickhulce]

we can simplify this more now too, just record.resourceType === :)

[patrickhulce]

same here :)

[wardpeet]

i'll just leave it be and just fix the ones I already have in this PR.

I thank the all seeing eye of @patrickhulce 😄

[patrickhulce]

WFM thanks for bringing it up! :)