misc(i18n): add assertion script #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
i18n_assert
branch
from
0e8701c
to
5e3c7b5
Compare
paulirish
approved these changes
Jul 19, 2018
| colorText "✅ PASS. All strings have been collected." "$green" | ||
| else | ||
| colorText "❌ FAIL. Strings have changed." "$red" | ||
| echo "Commit the changes to `lighthouse-core/lib/locales/` update the strings." |
There was a problem hiding this comment.
in bash, backticks evaluate. ;)
so this actually triggers this error: assert-strings-collected.sh: line 48: lighthouse-core/lib/locales/: Is a directory
There was a problem hiding this comment.
haha, whoops! that'll show me to make aesthetic changes after running :)
paulirish
reviewed
Jul 19, 2018
| function teardown { rm -f "$currentstringsPath" "$freshstringsPath"; } | ||
| trap teardown EXIT | ||
|
|
||
| cp $collectedstringsPath $currentstringsPath |
There was a problem hiding this comment.
actually wanna throw quotes around these paths? shellcheck prefers it like that in case there are spaces in my project path. (hint: there aren't)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an assertion script to make sure we keep the strings up to date