misc(asset-saver): tweak output format of logAssets #5696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Jul 20, 2018
| const traceIter = traceJsonGenerator(passAssets.traceData); | ||
| let traceJson = ''; | ||
| for (const trace of traceIter) { | ||
| traceJson += trace; | ||
| } | ||
| log.log(`trace-${passAssets.passName}.json`, traceJson); | ||
| // eslint-disable-next-line no-console | ||
| console.log(`loggedAsset %%% trace-${passAssets.passName}.json %%% ${traceJson}`); |
There was a problem hiding this comment.
is there still the max console.log length problem or was that fixed?
| @@ -326,13 +326,16 @@ async function saveAssets(artifacts, audits, pathWithBasename) { | |||
| async function logAssets(artifacts, audits) { | |||
| const allAssets = await prepareAssets(artifacts, audits); | |||
| allAssets.map(passAssets => { | |||
| log.log(`devtoolslog-${passAssets.passName}.json`, JSON.stringify(passAssets.devtoolsLog)); | |||
| const dtlogdata=JSON.stringify(passAssets.devtoolsLog); | |||
There was a problem hiding this comment.
nah it's more straightforward without any extra whitespace
There was a problem hiding this comment.
nah it's more straightforward without any extra whitespace
uh...wha?
There was a problem hiding this comment.
OHHH i thought the suggestion was to add a spaceindent arg to stringify. :) 🤡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For slightly cleaner log retrieval from lightrider